Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbit: add rabbit.mapping key to rabbit config #292

Merged

Conversation

jameshcorbett
Copy link
Member

Problem: there is no documentation for the rabbit.mapping config key.

Add it.

@jameshcorbett jameshcorbett requested a review from wihobbs January 25, 2025 00:20
Copy link
Member

@wihobbs wihobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everyone knows rabbits live in meadows, why do we need a map?

@jameshcorbett
Copy link
Member Author

They live in tuolumne meadows though and most people don't know how to get there, they only know how to get to the valley. It looks like spell-and-linkcheck is BORKEN

@wihobbs
Copy link
Member

wihobbs commented Jan 25, 2025

I think we have allowed deprecated dependencies in the rabbit habitat! The rabbits are beside themselves!

@jameshcorbett jameshcorbett force-pushed the add-rabbitmapping-to-docs branch from e360b88 to 6a79efd Compare January 25, 2025 00:46
@wihobbs
Copy link
Member

wihobbs commented Jan 25, 2025

This'll need a rebase but then it's good to go!

Problem: there is no documentation for the rabbit.mapping config key.

Add it.
Problem: code snippets in the rabbit docs are formatted incorrectly
because they only use single backticks.

Change to double backticks.
@jameshcorbett jameshcorbett force-pushed the add-rabbitmapping-to-docs branch from e223091 to 545ec8b Compare January 25, 2025 01:45
@jameshcorbett jameshcorbett added merge-when-passing mark PR for auto-merging by mergify.io bot and removed merge-when-passing mark PR for auto-merging by mergify.io bot labels Jan 25, 2025
@jameshcorbett
Copy link
Member Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jan 25, 2025

refresh

✅ Pull request refreshed

@jameshcorbett
Copy link
Member Author

Can you merge it manually @wihobbs ?

@wihobbs wihobbs removed the merge-when-passing mark PR for auto-merging by mergify.io bot label Jan 27, 2025
@wihobbs wihobbs added documentation Improvements or additions to documentation merge-when-passing mark PR for auto-merging by mergify.io bot labels Jan 27, 2025
@wihobbs wihobbs merged commit 920fafe into flux-framework:master Jan 27, 2025
5 checks passed
@wihobbs
Copy link
Member

wihobbs commented Jan 27, 2025

Done. Thanks @jameshcorbett!

@jameshcorbett jameshcorbett deleted the add-rabbitmapping-to-docs branch January 27, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants